feat: Inline plugins (plugins without running VM2) #23443
Conversation
oliverb123
changed the title
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
oliverb123
force-pushed
the
oliver_plugin_inlining
branch
from
fd9f9c3 to
13545fc
Compare
oliverb123
force-pushed
the
oliver_plugin_inlining
branch
from
b29d269 to
b32c926
Compare
oliverb123
changed the title
oliverb123
force-pushed
the
oliver_plugin_inlining
branch
from
1955e54 to
61bd215
Compare
oliverb123
force-pushed
the
oliver_plugin_inlining
branch
4 times, most recently
from
b84b06f to
e0029b1
Compare
There was a problem hiding this comment.
This is super cool. Some really clean work here (especially when working with such a messy problem!) Only one suggestion regarding tests but not blocking.
We might want to be extra careful merging this. I haven't tried it locally so worth triple checking and if there is any doubts doing a canary style deploy (with support from infra)
There was a problem hiding this comment.
I was expecting to find a test for this tbh. At least one happy path test per inline plugin would be great
There was a problem hiding this comment.
I took the tests from the plugin repo and put them in inline.test.ts (the semvar-flattener one) - does this cover the kind of testing you mean, or something beyond that?
There was a problem hiding this comment.
I'm not sure if it's what he meant, but seeing a functional test that actually calls an inline plugin would be nice (maybe I'm missing one?)
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
oliverb123
force-pushed
the
oliver_plugin_inlining
branch
from
889c186 to
05aa95a
Compare
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben White <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben White <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben White <[email protected]>
Problem
Plugins run inside a VM, which incurs memory and cpu overhead, and code complexity. As many plugins are now considered trusted-source in cloud environments, we can inline the code for commonly used plugins instead, focusing for now on processEvent plugins, to get some improved performance in the ingestion pipeline.